Skip to content

Commit

Permalink
feat: support apiEndpoint override in client constructor (#289)
Browse files Browse the repository at this point in the history
  • Loading branch information
yoshi-automation authored and JustinBeckwith committed Jun 5, 2019
1 parent 437cca6 commit a420d96
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,18 @@ class TranslationServiceClient {
* API remote host.
*/
constructor(opts) {
opts = opts || {};
this._descriptors = {};

const servicePath =
opts.servicePath || opts.apiEndpoint || this.constructor.servicePath;

// Ensure that options include the service address and port.
opts = Object.assign(
{
clientConfig: {},
port: this.constructor.port,
servicePath: this.constructor.servicePath,
servicePath,
},
opts
);
Expand Down Expand Up @@ -231,6 +235,14 @@ class TranslationServiceClient {
return 'translate.googleapis.com';
}

/**
* The DNS address for this API service - same as servicePath(),
* exists for compatibility reasons.
*/
static get apiEndpoint() {
return 'translate.googleapis.com';
}

/**
* The port for this API service.
*/
Expand Down
10 changes: 5 additions & 5 deletions packages/google-cloud-translate/synth.metadata
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"updateTime": "2019-05-29T11:22:38.021811Z",
"updateTime": "2019-06-05T14:29:10.487929Z",
"sources": [
{
"generator": {
"name": "artman",
"version": "0.21.0",
"dockerImage": "googleapis/artman@sha256:28d4271586772b275cd3bc95cb46bd227a24d3c9048de45dccdb7f3afb0bfba9"
"version": "0.23.1",
"dockerImage": "googleapis/artman@sha256:9d5cae1454da64ac3a87028f8ef486b04889e351c83bb95e83b8fab3959faed0"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "fa15c3006e27b87a20c7a9ffbb7bbe4149c61387",
"internalRef": "250401304"
"sha": "47c142a7cecc6efc9f6f8af804b8be55392b795b",
"internalRef": "251635729"
}
},
{
Expand Down
23 changes: 23 additions & 0 deletions packages/google-cloud-translate/test/gapic-v3beta1.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,29 @@ const error = new Error();
error.code = FAKE_STATUS_CODE;

describe('TranslationServiceClient', () => {
it('has servicePath', () => {
const servicePath =
translateModule.v3beta1.TranslationServiceClient.servicePath;
assert(servicePath);
});

it('has apiEndpoint', () => {
const apiEndpoint =
translateModule.v3beta1.TranslationServiceClient.apiEndpoint;
assert(apiEndpoint);
});

it('has port', () => {
const port = translateModule.v3beta1.TranslationServiceClient.port;
assert(port);
assert(typeof port === 'number');
});

it('should create a client with no options', () => {
const client = new translateModule.v3beta1.TranslationServiceClient();
assert(client);
});

describe('translateText', () => {
it('invokes translateText without error', done => {
const client = new translateModule.v3beta1.TranslationServiceClient({
Expand Down

0 comments on commit a420d96

Please sign in to comment.