Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Iterator pull methods, add javadoc and tests #1041

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Implement Iterator pull methods, add javadoc and tests #1041

merged 1 commit into from
Jun 6, 2016

Conversation

mziccard
Copy link
Contributor

@mziccard mziccard commented Jun 3, 2016

This PR implements Iterator<ReceivedMessage> pull and Future<Iterator<ReceivedMessage>> pullAsync method.
This PR also:

  • Adds unit tests for pull methods
  • Adds system tests for pull methods, ack/nack messages and renewAckDeadline
  • Add shorter timeout for AckDeadlineRenewer tests
  • Add closed field to both PubSubImpl and DefaultPubSubRpc

@mziccard mziccard added the api: pubsub Issues related to the Pub/Sub API. label Jun 3, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 3, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.1% when pulling a881209 on mziccard:pubsub-pull-iterator into e3a6d2e on GoogleCloudPlatform:pubsub-alpha.

@mziccard
Copy link
Contributor Author

mziccard commented Jun 3, 2016

/cc @lesv

lesv
lesv reviewed Jun 6, 2016
View reviewed changes
gcloud-java-pubsub/src/test/java/com/google/cloud/pubsub/PubSubImplTest.java
pubsub = new PubSubImpl(options, renewerMock);
PullRequest request = PullRequest.newBuilder()
.setSubscription(SUBSCRIPTION_NAME_PB)
.setMaxMessages(42)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lesv
Copy link
Contributor

lesv commented Jun 6, 2016

LGTM - codacy/pr doesn't seem happy, but I couldn't find anything I agreed with it on.

@mziccard
Copy link
Contributor Author

mziccard commented Jun 6, 2016

@lesv thanks for the pass!

@mziccard mziccard merged commit 2fd2d56 into googleapis:pubsub-alpha Jun 6, 2016
aozarov
aozarov reviewed Jun 8, 2016
View reviewed changes
gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/PubSubImpl.java
@@ -16,9 +16,9 @@

package com.google.cloud.pubsub;

import static com.google.api.client.util.Preconditions.checkArgument;

This comment was marked as spam.

Sign in to view

@aozarov
Copy link
Contributor

aozarov commented Jun 8, 2016

I think this PR has a few things that need to be fixed.

This was referenced Jun 8, 2016
Merged
Merged
mziccard added a commit to mziccard/gcloud-java that referenced this pull request Jun 27, 2016
@mziccard
Implement Iterator pull methods, add javadoc and tests (googleapis#1041)
54e179c
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
@gcf-owl-bot
feat: add model_monitoring_stats_anomalies,model_monitoring_status to…
fe03c60 
… BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto (#1041)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 470845818

Source-Link: googleapis/googleapis@284389e

Source-Link: googleapis/googleapis-gen@29deb79
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjlkZWI3OWIwNGFlYTE2OWE1NjhlN2M1NDQ4NjgyNDNkNTE2MWRkZSJ9
github-actions bot pushed a commit that referenced this pull request Sep 19, 2022
@release-please
chore(main): release 3.3.0 (#1025)
9bd4e09 
🤖 I have created a release *beep* *boop*
---


## [3.3.0](googleapis/java-aiplatform@v3.2.0...v3.3.0) (2022-09-15)


### Features

* add input_artifacts to PipelineJob.runtime_config in aiplatform v1 pipeline_job ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab))
* Add model_monitoring_stats_anomalies,model_monitoring_status to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([#1041](googleapis/java-aiplatform#1041)) ([fe03c60](googleapis/java-aiplatform@fe03c60))
* Add read_mask to ListPipelineJobsRequest in aiplatform v1 pipeline_service ([#1032](googleapis/java-aiplatform#1032)) ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab))
* Add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1 index_service.proto ([#1030](googleapis/java-aiplatform#1030)) ([4114021](googleapis/java-aiplatform@4114021))
* add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1beta1 index_service.proto ([4114021](googleapis/java-aiplatform@4114021))
* Add WriteFeatureValues in aiplatform v1beta1 featurestore_online_service.proto ([#1022](googleapis/java-aiplatform#1022)) ([267827e](googleapis/java-aiplatform@267827e))


### Dependencies

* Update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.18.0 ([#1021](googleapis/java-aiplatform#1021)) ([c3d34a0](googleapis/java-aiplatform@c3d34a0))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#1016](googleapis/java-aiplatform#1016)) ([cc0af7b](googleapis/java-aiplatform@cc0af7b))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#1026](googleapis/java-aiplatform#1026)) ([6ed66cc](googleapis/java-aiplatform@6ed66cc))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#1031](googleapis/java-aiplatform#1031)) ([5adefd4](googleapis/java-aiplatform@5adefd4))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#1040](googleapis/java-aiplatform#1040)) ([b6c1b20](googleapis/java-aiplatform@b6c1b20))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#1044](googleapis/java-aiplatform#1044)) ([5ce52e5](googleapis/java-aiplatform@5ce52e5))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1043](googleapis/java-aiplatform#1043)) ([40eae55](googleapis/java-aiplatform@40eae55))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1045](googleapis/java-aiplatform#1045)) ([0f66302](googleapis/java-aiplatform@0f66302))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1015](googleapis/java-aiplatform#1015)) ([7a2fcb0](googleapis/java-aiplatform@7a2fcb0))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
@release-please
chore(main): release 2.2.13-SNAPSHOT (#1041)
1702049 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@renovate-bot
deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1…
0637da1 
….6.20 (#1041)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.18` -> `1.6.20` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.20/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.20/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.20/compatibility-slim/1.6.18)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.20/confidence-slim/1.6.18)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam</summary>

### [`v1.6.20`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;1620-httpsgithubcomgoogleapisjava-iamcomparev1619v1620-2022-11-22)

[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.19...v1.6.20)

##### Dependencies

-   Update dependency com.google.cloud:google-iam-policy to v1.6.19 ([#&#8203;551](https://togithub.com/googleapis/java-iam/issues/551)) ([cd4a411](https://togithub.com/googleapis/java-iam/commit/cd4a411647e67ebe88c690d6ca4532d4011b4029))

### [`v1.6.19`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;1619-httpsgithubcomgoogleapisjava-iamcomparev1618v1619-2022-11-22)

[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.18...v1.6.19)

##### Dependencies

-   Update dependency com.google.cloud:google-iam-policy to v1.6.18 ([#&#8203;548](https://togithub.com/googleapis/java-iam/issues/548)) ([34ed3ea](https://togithub.com/googleapis/java-iam/commit/34ed3ea40572a3598d372e9c9d6d5a4077de86d6))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMC4yIiwidXBkYXRlZEluVmVyIjoiMzQuMzAuMiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mziccard @coveralls @lesv @aozarov @googlebot