Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for entities with incomplete key to Datastore.put #1040

Merged
merged 1 commit into from
Jun 8, 2016
Merged

Add support for entities with incomplete key to Datastore.put #1040

merged 1 commit into from
Jun 8, 2016

Conversation

mziccard
Copy link
Contributor

@mziccard mziccard commented Jun 2, 2016

Support is also added to DatastoreBatchWriter. This fixes #638

/cc @lesv @aozarov @ajkannan

@mziccard mziccard added the api: datastore Issues related to the Datastore API. label Jun 2, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 86.065% when pulling 64883fc on mziccard:datastore-put into d3a49ea on GoogleCloudPlatform:master.

@lesv
Copy link
Contributor

lesv commented Jun 6, 2016

please take codacy/pr's suggestion.
Isn't this incomplete keys, not incomplete entities? Perhaps you should change the title of this PR.
Once that is done, I'm happy w/ your code.

@lesv
Copy link
Contributor

lesv commented Jun 6, 2016

I'm going to have to read a bunch more code, but it appears that most operations are buffered, do we have guarantees of when writes actually happen? Must they be within transactions?

@mziccard
Copy link
Contributor Author

mziccard commented Jun 6, 2016

I'm going to have to read a bunch more code, but it appears that most operations are buffered, do we have guarantees of when writes actually happen? Must they be within transactions?

BaseDatastoreBatchWriter is further extended in BatchImpl and TransactionImpl that have explicit methods to make writes happen: submit and commit respectively (TransactionImpl also has rollback).

@lesv
Copy link
Contributor

lesv commented Jun 7, 2016

Thanks - LGTM after you remove the two final's suggested by codacy/pr.

@mziccard mziccard changed the title Add support for incomplete entities to Datastore.put Add support for entities with incomplete key to Datastore.put Jun 8, 2016
@mziccard mziccard merged commit eb6f182 into googleapis:master Jun 8, 2016
@aozarov
Copy link
Contributor

aozarov commented Jun 8, 2016

Looks good!

@mziccard mziccard mentioned this pull request Jul 22, 2016
Closed
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-bigquery to v2.…
b6c1b20 
…15.0 (#1040)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.14.7` -> `2.15.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.15.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.15.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.15.0/compatibility-slim/2.14.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.15.0/confidence-slim/2.14.7)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-bigquery</summary>

### [`v2.15.0`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#&#8203;2150-httpsgithubcomgoogleapisjava-bigquerycomparev2147v2150-2022-08-25)

[Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.14.7...v2.15.0)

##### Features

-   add preview support for default values ([#&#8203;2244](https://togithub.com/googleapis/java-bigquery/issues/2244)) ([fd3d3c5](https://togithub.com/googleapis/java-bigquery/commit/fd3d3c57afed84b4d00aab438d79472a6afa001b))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE3Ni4wIn0=-->
github-actions bot pushed a commit that referenced this pull request Sep 19, 2022
@release-please
chore(main): release 3.3.0 (#1025)
9bd4e09 
🤖 I have created a release *beep* *boop*
---


## [3.3.0](googleapis/java-aiplatform@v3.2.0...v3.3.0) (2022-09-15)


### Features

* add input_artifacts to PipelineJob.runtime_config in aiplatform v1 pipeline_job ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab))
* Add model_monitoring_stats_anomalies,model_monitoring_status to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([#1041](googleapis/java-aiplatform#1041)) ([fe03c60](googleapis/java-aiplatform@fe03c60))
* Add read_mask to ListPipelineJobsRequest in aiplatform v1 pipeline_service ([#1032](googleapis/java-aiplatform#1032)) ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab))
* Add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1 index_service.proto ([#1030](googleapis/java-aiplatform#1030)) ([4114021](googleapis/java-aiplatform@4114021))
* add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1beta1 index_service.proto ([4114021](googleapis/java-aiplatform@4114021))
* Add WriteFeatureValues in aiplatform v1beta1 featurestore_online_service.proto ([#1022](googleapis/java-aiplatform#1022)) ([267827e](googleapis/java-aiplatform@267827e))


### Dependencies

* Update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.18.0 ([#1021](googleapis/java-aiplatform#1021)) ([c3d34a0](googleapis/java-aiplatform@c3d34a0))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#1016](googleapis/java-aiplatform#1016)) ([cc0af7b](googleapis/java-aiplatform@cc0af7b))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#1026](googleapis/java-aiplatform#1026)) ([6ed66cc](googleapis/java-aiplatform@6ed66cc))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#1031](googleapis/java-aiplatform#1031)) ([5adefd4](googleapis/java-aiplatform@5adefd4))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#1040](googleapis/java-aiplatform#1040)) ([b6c1b20](googleapis/java-aiplatform@b6c1b20))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#1044](googleapis/java-aiplatform#1044)) ([5ce52e5](googleapis/java-aiplatform@5ce52e5))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1043](googleapis/java-aiplatform#1043)) ([40eae55](googleapis/java-aiplatform@40eae55))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1045](googleapis/java-aiplatform#1045)) ([0f66302](googleapis/java-aiplatform@0f66302))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1015](googleapis/java-aiplatform#1015)) ([7a2fcb0](googleapis/java-aiplatform@7a2fcb0))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
@release-please
chore(main): release 2.2.12 (#1040)
0aa5579 
🤖 I have created a release *beep* *boop*
---


## [2.2.12](https://togithub.com/googleapis/java-video-intelligence/compare/v2.2.11...v2.2.12) (2022-10-04)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1039](https://togithub.com/googleapis/java-video-intelligence/issues/1039)) ([50bbb9e](https://togithub.com/googleapis/java-video-intelligence/commit/50bbb9e81423d724d2cd0543693a0fe5e7d97991))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@renovate-bot
deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1…
cd0b3d1 
….6.18 (#1040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support put for parameters of type FullEntity<IncompleteKey> in v1beta3
5 participants
@mziccard @coveralls @lesv @aozarov @googlebot