Specify convertFieldsToCamelCase to true by default #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is wanted for idiomatic nodejs clients -- all of the internal fields will be lowercased_underscore style. Fixes googleapis#43, and googleapis#41.
|
cc: @jmdobry |
geigerj
reviewed
Sep 27, 2016
| @@ -89,6 +89,9 @@ GrpcClient.prototype.load = function(args) { | |||
| } else if (!Array.isArray(args)) { | |||
| args = [args]; | |||
| } | |||
| if (args.length == 1) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Current coverage is 92.84% (diff: 100%)@@ master #44 diff @@
==========================================
Files 8 8
Lines 951 951
Methods 129 129
Messages 0 0
Branches 208 208
==========================================
Hits 883 883
Misses 68 68
Partials 0 0
|
| @@ -7,7 +7,7 @@ | |||
| "chai": "*", | |||
| "eventemitter2": "~2.0.2", | |||
| "google-auto-auth": "~0.2.4", | |||
| "grpc": "~0.15.0", | |||
| "grpc": "~1.0", | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
geigerj
approved these changes
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is wanted for idiomatic nodejs clients -- all of the internal
fields will be lowercased_underscore style.
Fixes #43, and #41.