Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to default convertFieldsToCamelCase to true #43

Closed
jmdobry opened this issue Sep 27, 2016 · 0 comments
Closed

Need to default convertFieldsToCamelCase to true #43

jmdobry opened this issue Sep 27, 2016 · 0 comments
Assignees
@yoshi-automation
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@jmdobry
Copy link

jmdobry commented Sep 27, 2016

or at least provide a way for it to be configured when building a client. Right now it's basically hard-coded false with no way to change it.

See googleapis/google-cloud-node#1631 (comment) for context.

Here is what needs fixing: https://github.com/googleapis/gax-nodejs/blob/master/lib/grpc.js#L92
@jmuk jmuk self-assigned this Sep 27, 2016
jmuk added a commit to jmuk/toolkit that referenced this issue Sep 27, 2016
@jmuk
Update naming of grpc fields.
da388a6 
Updates googleapis/gax-nodejs#43
jmuk added a commit to jmuk/gax-nodejs that referenced this issue Sep 27, 2016
@jmuk
Specify convertFieldsToCamelCase to true by default
c86eaab 
This is wanted for idiomatic nodejs clients -- all of the internal
fields will be lowercased_underscore style.

Fixes googleapis#43, and googleapis#41.
This was referenced Sep 27, 2016
Merged
Merged
jmuk added a commit to googleapis/gapic-generator that referenced this issue Sep 27, 2016
@jmuk
Update naming of grpc fields. (#520)
4f42626 
Updates googleapis/gax-nodejs#43
@jmuk jmuk closed this as completed in #44 Sep 27, 2016
jmuk added a commit that referenced this issue Sep 27, 2016
@jmuk
Specify convertFieldsToCamelCase to true by default (#44)
4d2aacf 
This is wanted for idiomatic nodejs clients -- otherwise all of the internal
fields will be lowercased_underscore style.

Also this CL updates grpc dependency to 1.0.0, and
fix a typo in grpc.js.

Fixes #43, and #41.
@jmuk jmuk reopened this Sep 27, 2016
jmuk added a commit to jmuk/toolkit that referenced this issue Sep 27, 2016
@jmuk
Yet another fix for lowerCamel field names.
1e9d75b 
Fixes googleapis/gax-nodejs#43
@jmuk jmuk mentioned this issue Sep 27, 2016
Merged
jmuk added a commit to googleapis/gapic-generator that referenced this issue Sep 28, 2016
@jmuk
Yet another fix for lowerCamel field names. (#527)
184ab47 
Fixes googleapis/gax-nodejs#43
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmuk @jmdobry @yoshi-automation