-
Notifications
You must be signed in to change notification settings - Fork 129
Add sample_type field to permit in-code samples. #2996
Conversation
// in-code samples for the same RPC before including them in the | ||
// library source code). If not specified or empty, defaults to | ||
// ["standalone"] | ||
repeated string sample_type = 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not compiling - please add a comma after 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Done
ac7b0dd
to
adf6359
Compare
src/main/proto/com/google/api/codegen/samplegen/v1p2/sample_config_v1p2.proto
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please address Ruby failure before merging
(Looking at commit history of gapic-generator there doesn't seem to be any change related to Ruby unit tests for a while. So the failure could be due to a change in some dependencies)
Is this review still open? |
b525fb6
to
d1fb3a8
Compare
d1fb3a8
to
5f7c51b
Compare
Merged with master. I had to tweak the circle config file to make CircleCI pass on my fork. For some reason, the I don't know why this was passing on the main repo even though it was failing on my fork. PTAL @hzyi-google @software-dov @jbolinger |
This is an optional field in the sample config. If it is not provided, generators should emit standalone samples only for the given config. (This preserves backward compatibility with uses of the current schema.)