Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Ensure we don't generate standalone samples if sample_type says not to #3015

Closed
vchudnov-g opened this issue Nov 1, 2019 · 2 comments
Closed

Ensure we don't generate standalone samples if sample_type says not to #3015

vchudnov-g opened this issue Nov 1, 2019 · 2 comments
Assignees
@yihanzhen
Labels
Core: Sample-gen priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@vchudnov-g
Copy link
Contributor

As of #2996 , there is now a sample_type field in the sample config. If not present, it defaults to standalone samples, so current configs will continue to work.

However, some upcoming configs may have it set to produce in-code samples only. In that case, we should make sure we don't produce standalone samples.
@vchudnov-g vchudnov-g added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. Core: Sample-gen labels Nov 1, 2019
@vchudnov-g
Copy link
Contributor Author

Update: We're putting samplegen eng work on hold for 2020q1, but this will need to be addressed when we resume.

@yihanzhen
Copy link
Contributor

Moved to backlog: https://github.com/googleapis/gapic-generator/wiki/feature-backlog

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yihanzhen yihanzhen

Labels
Core: Sample-gen priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vchudnov-g @yihanzhen