Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

WIP: java: move CredentialsProvider up to ClientSettings #1319

Merged
merged 4 commits into from
Jun 7, 2017
Merged

WIP: java: move CredentialsProvider up to ClientSettings #1319

merged 4 commits into from
Jun 7, 2017

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Jun 2, 2017

redo of #1251.

WIP pending more tests, but all generated code's
unit tests run OK against updated gax.

Adding Neo since a similar change broke his code earlier.

@pongad pongad changed the title java: move CredentialsProvider up to ClientSettings WIP: java: move CredentialsProvider up to ClientSettings Jun 2, 2017
@codecov-io
Copy link

codecov-io commented Jun 2, 2017

Codecov Report

Merging #1319 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1319      +/-   ##
============================================
+ Coverage     86.47%   86.47%   +<.01%     
  Complexity     3838     3838              
============================================
  Files           378      378              
  Lines         15332    15336       +4     
  Branches       1696     1696              
============================================
+ Hits          13258    13262       +4     
  Misses         1623     1623              
  Partials        451      451
Impacted Files Coverage Δ Complexity Δ
...nsformer/java/JavaGapicSurfaceTestTransformer.java 100% <100%> (ø) 27 <0> (ø) ⬇️
.../transformer/java/JavaGapicSurfaceTransformer.java 98.13% <100%> (+0.01%) 43 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b390ad...6f2a4d2. Read the comment docs.

redo of #1251.

WIP pending more tests, but all generated code's
unit tests run OK against updated gax.
@garrettjonesgoogle
Copy link
Member

LGTM - this will work as an intermediate state until my refactoring is done.

@garrettjonesgoogle
Copy link
Member

This seems good to go, is there anything left to do?

@pongad
Copy link
Contributor Author

pongad commented Jun 6, 2017

I forgot to update the baseline. Will do that and merge.

@pongad pongad merged commit 79d47ad into googleapis:master Jun 7, 2017
@pongad pongad deleted the client-context branch June 7, 2017 04:21
pongad added a commit to googleapis/artman that referenced this pull request Jun 16, 2017
Update toolkit to latest version to
bring in changes from googleapis/gapic-generator#1319.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants