Skip to content
This repository has been archived by the owner on Mar 1, 2022. It is now read-only.

update toolkit #221

Merged
merged 1 commit into from
Jun 16, 2017
Merged

update toolkit #221

merged 1 commit into from
Jun 16, 2017

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Jun 15, 2017

Update toolkit to latest version to
bring in changes from googleapis/gapic-generator#1319.

Update toolkit to latest version to
bring in changes from googleapis/gapic-generator#1319.
@pongad pongad requested a review from ethanbao June 15, 2017 00:58
@ethanbao
Copy link
Contributor

ethanbao commented Jun 15, 2017

The current smoketest running in circle CI catch potential issue with this Dockerfile change. Can you run the following in your local machine, and make sure the local toolkit is synced to the exact commit:

docker run -it \
        -v ${PWD}:/usr/src/artman \
        -v {REPLACE_WITH_LOCAL_TOOLKIT_DIR}:/toolkit \
        googleapis/artman:latest \
        /bin/bash -c  "pip uninstall -y googleapis-artman; \
        pip install -e /usr/src/artman/; \
        /usr/src/artman/test/smoketest_artman.py --apis=pubsub,vision"

@pongad
Copy link
Contributor Author

pongad commented Jun 16, 2017

@ethanbao I think this is because an update to toolkit requires a change in googleapis. If I also add a

-v $GOOGLEAPIS_PATH:/googleapis

everything works OK. Does this complicate matters?

For my own information, how much work is it to sync after the dockerfile is changed? If the work is significant, I'll try to batch changes in the future.

@ethanbao
Copy link
Contributor

Your change is good. Use of commit hash is a temporary workaround because toolkit itself doesn't have its own release yet. The problem will eventually be how toolkit decides the cut of its release.

@pongad pongad merged commit 01f753f into googleapis:master Jun 16, 2017
@pongad pongad deleted the update-toolkit branch June 16, 2017 06:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants