Merging latest changes in to CDep branch #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue #6 - they were reversed
oboe: fix dlsym for getFramesWritten/Read
oboe callback: remove onExit()
I get compilation "error: use of undeclared identifier 'memcpy'" Adding the memory.h include fixes this.
Update FifoBuffer.cpp
WARNING: API change Modifies OboeStreamCallback onError methods. Adds protection against stopping or closing a stream at the same time that the error callback is being processed. Fix issue #1
oboe: automatically stop and close a stream when disconnected
New namespace, constexprs and scoped enums
Clearer explanation for exclusive sharing mode
Put Engine and OutputMixer into Singleton classes. Create separate input and output classes.
Also fix some bugs in OpenSL ES implementation and replace asserts with error returns.
add input capture support to OpenSL wrapper
Make it consistent with the earlier instructions which say put the Oboe commands at the end of the file.
Adding version information
Add disconnected state
Rename ApiIndex to AudioApi, move into Definitions.h
Adding unit tests and testing script
From #40, it seems that AAudio on Android 8.0 isn't stable enough. As a safety measure, always fall back to OpenSL ES on it.
Do not use AAudio unless running on Android 8.1 or higher
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.