You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Yes. it is going to be hard to keep those in sync. Maybe we could parse the VERSION info from "Version.h". There is probably some grep/sed voodoo that will do this quickly.
The reason will be displayed to describe this comment to others. Learn more.
I'm going to remove the CDep stuff for now. The current source-only distribution method seems to be working quite well, and it avoids having to recompile and publish binaries for each architecture each time we make a change.
c51f2ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should version that we put into CDep manifest from "build_all_android.sh" also be updated?
c51f2ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. it is going to be hard to keep those in sync. Maybe we could parse the VERSION info from "Version.h". There is probably some grep/sed voodoo that will do this quickly.
c51f2ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to remove the CDep stuff for now. The current source-only distribution method seems to be working quite well, and it avoids having to recompile and publish binaries for each architecture each time we make a change.
c51f2ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CDep and build script can be found here now: https://github.com/google/oboe/tree/cdep.
One other thing is that the README version history should also be updated with a brief description of the change: https://github.com/google/oboe/blob/cdep/README.md#version-history