Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiveEffect should process samples from input to output. #852

Closed
philburk opened this issue May 12, 2020 · 0 comments · Fixed by #1114
Closed

LiveEffect should process samples from input to output. #852

philburk opened this issue May 12, 2020 · 0 comments · Fixed by #1114
Assignees
@philburk

Comments

@philburk
Copy link
Collaborator

Instead of using memcpy(), the sample code should move each sample from input to output.
That will make it easier for developers to make changes.
We could, for example, apply a gain change of 0.9 to each sample.

https://github.com/google/oboe/blob/master/samples/LiveEffect/src/main/cpp/FullDuplexPass.h
@philburk philburk assigned ggfan and android-usb and unassigned ggfan May 12, 2020
@philburk philburk mentioned this issue May 12, 2020
Closed
This was referenced May 20, 2020
Closed
Closed
@griffinperry griffinperry mentioned this issue Jun 19, 2020
Closed
philburk added a commit that referenced this issue Nov 25, 2020
@philburk
Liveeffect: fix crash on exit
57cf274 
Use std::shared_ptr in FullDuplexStream.
Explicitly process the samples in the callback instead
of just using memcpy. This will be easier to modify.

Fixes #1113
Fixes #852
@philburk philburk assigned philburk and unassigned android-usb Nov 25, 2020
@philburk philburk mentioned this issue Nov 25, 2020
Merged
dturner pushed a commit that referenced this issue Nov 26, 2020
@philburk @dturner
Liveeffect: fix crash on exit
00039f7 
Use std::shared_ptr in FullDuplexStream.
Explicitly process the samples in the callback instead
of just using memcpy. This will be easier to modify.

Fixes #1113
Fixes #852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Liveeffect: fix crash on exit google/oboe
3 participants
@philburk @ggfan @android-usb