Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiveEffect crashes on exit #1113

Closed
philburk opened this issue Nov 25, 2020 · 0 comments · Fixed by #1114
Closed

LiveEffect crashes on exit #1113

philburk opened this issue Nov 25, 2020 · 0 comments · Fixed by #1114
Assignees
@philburk
Labels
bug P1 high priority
Milestone
v1.5

Comments

@philburk
Copy link
Collaborator

philburk commented Nov 25, 2020 •
edited
Loading

Android version(s): RQ1A
Android device(s): Pixel 3a
Oboe version: 1.5.0 candidate
App name used for testing: LiveEffect

Short description
LiveEffect has a native crash with a NULL pointer of bad address when exiting.

Steps to reproduce
In a terminal: adb logcat *:F
Launch LiveEffect
Select OpenSL ES (optional)
Tap START
Tap STOP
Tap BACK button

Expected behavior

No crash.

Actual behavior

Crash observed in logcat.

11-25 13:59:22.288 11461 11461 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0xc1f9830000000071

11-25 13:59:22.569 11461 11461 F DEBUG : #00 pc 000000000005adc4 /data/app/~~FRTqKF6YenZJ5qAzAEGRgA==/com.google.oboe.samples.liveeffect-xvcrj64_iTK-Y60sIUJSdQ==/lib/arm64/libliveEffect.so (FullDuplexStream::stop()+76) (BuildId: 0958e065dd7daeb4923f76935971a9ba50480c0a)
11-25 13:59:22.569 11461 11461 F DEBUG : #1 pc 0000000000058de0 /data/app/~~FRTqKF6YenZJ5qAzAEGRgA==/com.google.oboe.samples.liveeffect-xvcrj64_iTK-Y60sIUJSdQ==/lib/arm64/libliveEffect.so (LiveEffectEngine::~LiveEffectEngine()+64) (BuildId: 0958e065dd7daeb4923f76935971a9ba50480c0a)
11-25 13:59:22.569 11461 11461 F DEBUG : #2 pc 0000000000058ffc /data/app/~~FRTqKF6YenZJ5qAzAEGRgA==/com.google.oboe.samples.liveeffect-xvcrj64_iTK-Y60sIUJSdQ==/lib/arm64/libliveEffect.so (LiveEffectEngine::~LiveEffectEngine()+36) (BuildId: 0958e065dd7daeb4923f76935971a9ba50480c0a)
11-25 13:59:22.569 11461 11461 F DEBUG : #3 pc 000000000005b1e0 /data/app/~~FRTqKF6YenZJ5qAzAEGRgA==/com.google.oboe.samples.liveeffect-xvcrj64_iTK-Y60sIUJSdQ==/lib/arm64/libliveEffect.so (Java_com_google_oboe_samples_liveEffect_LiveEffectEngine_delete+68) (BuildId: 0958e065dd7daeb4923f76935971a9ba50480c0a)
@philburk philburk added the bug label Nov 25, 2020
@philburk philburk self-assigned this Nov 25, 2020
@philburk philburk added the P1 high priority label Nov 25, 2020
philburk added a commit that referenced this issue Nov 25, 2020
@philburk
Liveeffect: fix crash on exit
57cf274 
Use std::shared_ptr in FullDuplexStream.
Explicitly process the samples in the callback instead
of just using memcpy. This will be easier to modify.

Fixes #1113
Fixes #852
@philburk philburk mentioned this issue Nov 25, 2020
Merged
@philburk philburk added this to the v1.5 milestone Nov 25, 2020
dturner pushed a commit that referenced this issue Nov 26, 2020
@philburk @dturner
Liveeffect: fix crash on exit
00039f7 
Use std::shared_ptr in FullDuplexStream.
Explicitly process the samples in the callback instead
of just using memcpy. This will be easier to modify.

Fixes #1113
Fixes #852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
bug P1 high priority
Projects
None yet
Milestone
v1.5
Development

Successfully merging a pull request may close this issue.

Liveeffect: fix crash on exit google/oboe
1 participant
@philburk