Add Workload Identity status condition

[grac3gao-zz]

Based on @nachocano #703
Fixes #668

Proposed Changes

• Based on [Draft] PoC for Workload Identity status condition #703 to add status condition for Workload Identity by adding a duck identity duck type
• Cleanups for some Sources lifecycles methods
• Adding and fixing unit test

Release Note

Docs

[grac3gao-zz]

/retest

[grac3gao-zz]

Ready to review.

[nachocano]

Made a pass, just a few nits @grac3gao
I'm wondering if the secret should actually be made part of IdentitySpec as well... But that is something that can be done later on, if needed. Something to keep in mind...

[grac3gao-zz]

/retest

[nachocano]

Does it need to implement runtime.Object?

…

On Thu, Mar 26, 2020 at 4:27 PM Grace Gao ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pkg/apis/duck/v1alpha1/identity_types.go <#714 (comment)>: > +type IdentityList struct { + metav1.TypeMeta `json:",inline"` + metav1.ListMeta `json:"metadata"` + + Items []Identity `json:"items"` +} Looks like we can't do that...after running update-codegen and run unit test, it will fail in zz_generated.deepcopy.go, showing: IdentitySpec does not implement runtime.Object (missing GetObjectKind method) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#714 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABD65DFGTQYT3JVVO3MXEMDRJPQE5ANCNFSM4LT6OBKA> .

[grac3gao-zz]

@nachocano Tried several deletions ways, finally worked.

[nachocano]

@grac3gao add those TODOs @Harwayne suggested and the explanation of why we set the ready False in the WorkloadIdentityFailed condition, and we get this one in!

/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grac3gao, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nachocano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/duck/v1alpha1/identity_lifecycle.go	Do not exist	100.0%
pkg/apis/duck/v1alpha1/identity_types.go	Do not exist	100.0%
pkg/apis/events/v1alpha1/cloudauditlogssource_types.go	71.4%	75.0%	3.6
pkg/apis/events/v1alpha1/cloudpubsubsource_types.go	84.6%	86.7%	2.1
pkg/apis/events/v1alpha1/cloudschedulersource_types.go	66.7%	71.4%	4.8
pkg/apis/events/v1alpha1/cloudstoragesource_types.go	66.7%	71.4%	4.8
pkg/reconciler/events/auditlogs/auditlogs.go	92.2%	89.6%	-2.6
pkg/reconciler/events/pubsub/pubsub.go	76.7%	70.0%	-6.7
pkg/reconciler/events/scheduler/scheduler.go	84.3%	81.4%	-2.9
pkg/reconciler/events/storage/storage.go	82.3%	79.7%	-2.5
pkg/reconciler/identity/reconciler.go	76.3%	74.1%	-2.2
pkg/reconciler/messaging/channel/channel.go	80.9%	79.6%	-1.3

[grac3gao-zz]

@nachocano Just added those things. And I forgot to update the serviceAccountName in the status, so also include it.

[nachocano]

/lgtm

Thanks @grac3gao !!! Great work!