[Draft] PoC for Workload Identity status condition #703
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @grac3gao |
| // ServiceAccount is the GCP service account which has required permissions to poll from a Cloud Pub/Sub subscription. | ||
| // If not specified, defaults to use secret. | ||
| // +optional | ||
| ServiceAccount string `json:"serviceAccount,omitempty"` |
There was a problem hiding this comment.
@grac3gao I think you were right. I think we should call this something different, otherwise it might be confusing with a k8s service account. I'm inclined to call it gsa not to be too verbose with googleServiceAccount, but I don't have strong opinion...
This is lower priority, but something to keep in mind, because it changes a bunch of places..
| // +genduck | ||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
|
|
||
| type Identity struct { | ||
| metav1.TypeMeta `json:",inline"` | ||
| metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
|
||
| Spec PubSubSpec `json:"spec"` | ||
| Status PubSubStatus `json:"status"` | ||
| } |
There was a problem hiding this comment.
this duck is not even needed.
|
@nachocano: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Proposed Changes
Release Note
Docs
/hold won't submit this, it's just for demonstration purposes...