Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Use updated config to specify PubSub channel for Brokers #608

Merged

Conversation

zargarpur
Copy link
Contributor

Fixes #606

Proposed Changes

  • Add ConfigMap to default to PubSub Channels for Brokers
  • Update doc instructions to patch in ConfigMap reference

Release Note

Knative has updated the way Brokers determine which default Channel to use. Adding a ConfigMap that includes PubSub as the default. 

action required Follow updated instructions to patch Knative's ConfigMap to point use this configuration.

@knative-prow-robot
Copy link
Contributor

Welcome @zargarpur! It looks like this is your first PR to google/knative-gcp 🎉

@knative-prow-robot
Copy link
Contributor

Hi @zargarpur. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zargarpur
Copy link
Contributor Author

/assign @nachocano

@nachocano
Copy link
Member

nachocano commented Mar 5, 2020 via email

@nachocano
Copy link
Member

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, zargarpur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit b6aff75 into google:master Mar 6, 2020
@nachocano
Copy link
Member

Thanks for the quick fix @zargarpur!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the updated way of specifying a Broker's default Channel
4 participants