-
Notifications
You must be signed in to change notification settings - Fork 74
Use updated config to specify PubSub channel for Brokers #608
Use updated config to specify PubSub channel for Brokers #608
Conversation
Welcome @zargarpur! It looks like this is your first PR to google/knative-gcp 🎉 |
Hi @zargarpur. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @nachocano |
/ok-to-test
…On Thu, Mar 5, 2020 at 1:42 PM Al Zargarpur ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In config/default-broker-channel.yaml
<#608 (comment)>:
> + name: config-br-default-channel
+ namespace: cloud-run-events
I named this the same as in knative/eventing "config-br-default-channel",
but within the cloud-run-events namespace
https://github.com/knative/eventing/blob/master/config/core/configmaps/default-broker.yaml
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#608?email_source=notifications&email_token=ABD65DH6W6WDSW7DXHJUDDLRGAMF7A5CNFSM4LCSYVH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYGMPJI#pullrequestreview-369936293>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD65DBDYXVPKLNCBNBHURLRGAMF7ANCNFSM4LCSYVHQ>
.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano, zargarpur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the quick fix @zargarpur!!! |
Fixes #606
Proposed Changes
Release Note