Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Commit

Permalink
Use updated config to specify PubSub channel for Brokers (#608)
Browse files Browse the repository at this point in the history
* Use updated config to specify PubSub channel for Brokers

* Move & Rename & Symlink & Newline

* Move Symlink inside config/
  • Loading branch information
zargarpur authored Mar 6, 2020
1 parent 3b6987a commit b6aff75
Show file tree
Hide file tree
Showing 4 changed files with 50 additions and 4 deletions.
1 change: 1 addition & 0 deletions config/400-config-br-default-channel.yaml
23 changes: 23 additions & 0 deletions config/core/configmaps/config-br-default-channel.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Copyright 2020 The Knative Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

apiVersion: v1
kind: ConfigMap
metadata:
name: config-br-default-channel
namespace: cloud-run-events
data:
channelTemplateSpec: |
apiVersion: messaging.cloud.google.com/v1alpha1
kind: Channel
8 changes: 4 additions & 4 deletions docs/install/install-broker-with-pubsub-channel.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ Channel.

1. Patch the configmap in the `knative-eventing` namespace to use the Pub/Sub
`Channel` as the
[default channel](https://knative.dev/docs/eventing/channels/default-channels/)
with
[patch-default-ch-config-with-pubsub.yaml](./patch-default-ch-config-with-pubsub.yaml).
[default channel](https://knative.dev/docs/eventing/channel-based-broker/)
for Brokers with
[patch-config-br-defaults-with-pubsub.yaml](./patch-config-br-defaults-with-pubsub.yaml).

```shell
kubectl patch configmap default-ch-webhook -n knative-eventing --patch "$(cat patch-default-ch-config-with-pubsub.yaml)"
kubectl patch configmap config-br-defaults -n knative-eventing --patch "$(cat patch-config-br-defaults-with-pubsub.yaml)"
```

1. Add the `knative-eventing-injection` label to your namespace with the
Expand Down
22 changes: 22 additions & 0 deletions docs/install/patch-config-br-defaults-with-pubsub.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Copyright 2020 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

data:
# Configuration for defaulting channels that do not specify CRD implementations.
default-br-config: |
clusterDefault:
apiVersion: v1
kind: ConfigMap
name: config-br-default-channel
namespace: cloud-run-events

0 comments on commit b6aff75

Please sign in to comment.