Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Properly set system namespace when reconciling default brokercell #1715

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Properly set system namespace when reconciling default brokercell #1715

merged 1 commit into from
Sep 17, 2020

Conversation

ian-mi
Copy link
Contributor

@ian-mi ian-mi commented Sep 16, 2020

Backport #1705 into the release-0.15b branch.

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Sep 16, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ian-mi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/brokercell/controller.go 54.3% 77.3% 23.0

Harwayne
Harwayne reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ian-mi
Copy link
Contributor Author

ian-mi commented Sep 17, 2020

/retest

3 similar comments
@ian-mi
Copy link
Contributor Author

ian-mi commented Sep 17, 2020

/retest

@nachocano
Copy link
Member

/retest

@ian-mi
Copy link
Contributor Author

ian-mi commented Sep 17, 2020

/retest

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-integration-tests 0/3
pull-google-knative-gcp-wi-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-google-knative-gcp-wi-tests:

github.com/google/knative-gcp/test/e2e.TestGCPBrokerMetrics

@ian-mi
Copy link
Contributor Author

ian-mi commented Sep 17, 2020

/retest

2 similar comments
@nachocano
Copy link
Member

/retest

@grac3gao-zz
Copy link
Contributor

/retest

@knative-prow-robot knative-prow-robot merged commit d72d409 into google:release-0.15b Sep 17, 2020
@ian-mi ian-mi deleted the release-0.15b branch September 17, 2020 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Harwayne Harwayne Harwayne left review comments

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@Harwayne Harwayne

Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ian-mi @knative-prow-robot @knative-metrics-robot @nachocano @knative-test-reporter-robot @grac3gao-zz @Harwayne