Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Properly set system namespace when reconciling default brokercell #1705

Merged

Conversation

ian-mi
Copy link
Contributor

@ian-mi ian-mi commented Sep 15, 2020

Fixes #1704

Proposed Changes

  • Fix brokercell reconciliation so that it will be triggered by broker and trigger updates. Currently after creating or updating a broker the brokercell config will not be updated until it hits the resync period causing requests made to that broker to fail.

Release Note

- 🐛 Fix broker config reconcilation delay.

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Sep 15, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/brokercell/controller.go 48.7% 54.3% 5.6

@liu-cong
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ian-mi, liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brokercell reconcile not triggered by Broker Changes
4 participants