Fixing grpcio dependency behavior in devenv GRR container. #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpcio and grpcio-tools are effectively build-only dependency for GRR, but a runtime dependency for google-cloud-pubsub. To avoid versioning conflicts, we should install our own packages with separate `pip install` calls - this allows each call to override the version of grpcio or grpcio-tools if needed. This is clearly a hack. A proper fix is to migrate from setup.py to toml files and explicitly declare grpcio and grpcio-tools as GRR's build (and not runtime) dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpcio and grpcio-tools are effectively build-only dependency for GRR, but a runtime dependency for google-cloud-pubsub. To avoid versioning conflicts, we should install our own packages with separate
pip installcalls - this allows each call to override the version of grpcio or grpcio-tools if needed. This is clearly a hack. A proper fix is to migrate from setup.py to toml files and explicitly declare grpcio and grpcio-tools as GRR's build (and not runtime) dependencies.