Skip to content

Commit

Permalink
Fixing grpcio dependency behavior in devenv GRR container. (#1090)
Browse files Browse the repository at this point in the history
grpcio and grpcio-tools are effectively build-only dependency for GRR, but a runtime dependency for google-cloud-pubsub. To avoid versioning conflicts, we should install our own packages with separate `pip install` calls - this allows each call to override the version of grpcio or grpcio-tools if needed. This is clearly a hack. A proper fix is to migrate from setup.py to toml files and explicitly declare grpcio and grpcio-tools as GRR's build (and not runtime) dependencies.
  • Loading branch information
mbushkov authored May 27, 2024
1 parent 7cf5a07 commit 645c98f
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions devenv/src/containers/grr/Containerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,10 @@ RUN cd /grr/persist \

RUN cd /grr/src \
&& . /grr/persist/venv/bin/activate \
&& pip install \
-e grr/proto \
-e grr/core \
-e grr/client \
-e grr/client_builder \
-e api_client/python \
-e grr/server \
-e grr/test
&& pip install -e grr/proto \
&& pip install -e grr/core \
&& pip install -e grr/client \
&& pip install -e grr/client_builder \
&& pip install -e api_client/python \
&& pip install -e grr/server \
&& pip install -e grr/test

0 comments on commit 645c98f

Please sign in to comment.