Move stereoscopic debug options to Settings framework #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bejado
requested review from
pixelflinger,
z3moon,
elizagamedev and
poweifeng
z3moon
reviewed
Nov 10, 2023
| // window. | ||
| // For testing, we want to render a side-by-side layout so users can view with | ||
| // "cross-eyed" stereo. | ||
| // For cross-eyed stereo, Eye 0 is really the RIGHT eye, while Eye 1 is the LEFT eye. |
There was a problem hiding this comment.
Just curious, is there any reason why we didn't match the order of the eyes on the screen with the order of the array?
There was a problem hiding this comment.
So in fact we do, and maybe my comment is a little confusing. But eye 0 is always rendered to the left side of the screen, and eye 1 is rendered to the right side:
0 | 1
What this comment alludes to, is the fact that to render cross-eyed stereo, the left and right eyes need to be flipped.
pixelflinger
requested changes
Nov 10, 2023
pixelflinger
approved these changes
Nov 10, 2023
poweifeng
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a public
Engine::getConfigAPI, which helps simplify things.Fixes #7330