Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stereo option in ViewerGui doesn't use the Settings framework #7330

Closed
pixelflinger opened this issue Nov 2, 2023 · 0 comments · Fixed by #7347
Closed

stereo option in ViewerGui doesn't use the Settings framework #7330

pixelflinger opened this issue Nov 2, 2023 · 0 comments · Fixed by #7347
Assignees
Labels
android Issue/feature request for Android only bug Something isn't working web Issue/request for WASM/WebGL

Comments

@pixelflinger
Copy link
Collaborator

This code

        StereoscopicOptions stereoOptions = mView->getStereoscopicOptions();
        ImGui::Checkbox("Instanced stereo", &stereoOptions.enabled);
        if (stereoOptions.enabled) {
            ImGui::SliderFloat("Ocular distance", &mOcularDistance, 0.0f, 10.0f);

        }
        mView->setStereoscopicOptions(stereoOptions);

in ViewerGui.cpp is wrong because it will activate stereo on the UI context (when running on Web with remote ui). Like with all other settings, stereo must use the Settings framework or be moved to the Debug tab. However, for testing it would be much better that we can use this on devices.

@pixelflinger pixelflinger added bug Something isn't working android Issue/feature request for Android only web Issue/request for WASM/WebGL labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Issue/feature request for Android only bug Something isn't working web Issue/request for WASM/WebGL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants