-
Notifications
You must be signed in to change notification settings - Fork 83
Add SMS country picker for default code #656
Conversation
Fixes #649 |
/hold while it looks nice, it doesn't actually add the prefix... |
it does look nice! |
f4fb354
to
fe0d3a2
Compare
/unhold I forgot this is javascript submitted. |
let phone = document.querySelector('#phone'); | ||
let iti = window.intlTelInput(phone, { | ||
nationalMode: true, | ||
{{- if $currentRealm.SMSCountry }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...I should totally be making more use of {{-
for nicer layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really try to avoid it unless specifically required. I don't particularly care in HTML, but js is... finicky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Release Note