Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

nicer telephone widget #649

Closed
mikehelmick opened this issue Sep 23, 2020 · 8 comments · Fixed by #656 or #702
Closed

nicer telephone widget #649

mikehelmick opened this issue Sep 23, 2020 · 8 comments · Fixed by #656 or #702
Assignees
@sethvargo @whaught
Labels
kind/enhancement New feature or feature request.

Comments

@mikehelmick
Copy link
Contributor

mikehelmick commented Sep 23, 2020 •
edited by sethvargo
Loading

provide a drop down for international telephone input

possibly using: https://github.com/jackocnr/intl-tel-input

code issue is more important, SMS / MFA handling second.

let the realm set a default

/kind enhancement
@google-oss-robot google-oss-robot added the kind/enhancement New feature or feature request. label Sep 23, 2020
@sethvargo
Copy link
Member

Heh - I was gonna use that exact thing 😄

@sethvargo
Copy link
Member

/assign

@sethvargo sethvargo mentioned this issue Sep 23, 2020
Merged
@sethvargo sethvargo linked a pull request Sep 23, 2020 that will close this issue
Add SMS country picker for default code #656
Merged
@whaught
Copy link
Contributor

whaught commented Sep 23, 2020

Nice! I looked at that widget too for MFA...

@sethvargo
Copy link
Member

Did you mean widght? (making fun of Mike)

@whaught
Copy link
Contributor

whaught commented Sep 28, 2020

/reopen
/assign

@google-oss-robot
Copy link

@whaught: Reopened this issue.

In response to this:

/reopen
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@whaught whaught changed the title nicer telephone widght nicer telephone widget Sep 28, 2020
@whaught
Copy link
Contributor

whaught commented Sep 28, 2020

Reopening. I'm going to try to apply the same to the MFA registration UI

@sethvargo
Copy link
Member

Ah - I totally missed the "SMS/MFA is second" part.

@whaught whaught mentioned this issue Sep 28, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sethvargo sethvargo

@whaught whaught

Labels
kind/enhancement New feature or feature request.
Projects
None yet
Milestone
No milestone
4 participants
@mikehelmick @sethvargo @whaught @google-oss-robot