Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Copy pasta error #466

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Copy pasta error #466

merged 1 commit into from
Sep 2, 2020

Conversation

icco
Copy link
Contributor

@icco icco commented Sep 2, 2020

Fixes a bug in #465

Release Note

NONE

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 2, 2020
@icco
Copy link
Contributor Author

icco commented Sep 2, 2020

/assign @sethvargo

sethvargo
sethvargo approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit d4b5ec2 into google:main Sep 2, 2020
@google google locked and limited conversation to collaborators Oct 6, 2020
@icco icco deleted the typo branch October 6, 2020 20:51
@icco icco restored the typo branch October 6, 2020 20:52
@icco icco deleted the typo branch October 6, 2020 21:23
flagxor pushed a commit that referenced this pull request Aug 11, 2021
@odeke-em
observability: bring back ocagent after updating to v0.0.7 (#479)
28164e3 
Brings back the ocagent-exporter, after updating to
ocagent version v0.0.7 which uses newer dependencies of
the grpc-gateway, thus no longer needs the deprecated
"github.com/golang/protobuf/protoc-gen-go/generator"
package.

Fixes #466
Reverts #467
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icco @google-oss-robot @sethvargo