Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Fix bash command #479

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Fix bash command #479

merged 1 commit into from
Sep 7, 2020

Conversation

zssz
Copy link
Contributor

@zssz zssz commented Sep 5, 2020

No description provided.

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 5, 2020
@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 5, 2020
@google-oss-robot
Copy link

Hi @zssz. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@icco
Copy link
Contributor

icco commented Sep 7, 2020

I mean this is fine... but why though? Could you follow our pull request template to explain why this change is needed? It's functionally equivalent and just a matter of style afaik.

/hold
/Ok-to-test

@sethvargo
Copy link
Member

echo isn't the same on all systems. My guess they are running a version that doesn't support heredocs.

/unhold
/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: zssz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit ab9441a into google:main Sep 7, 2020
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants