This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Clean up nits from verification certification rotation #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Return proper response codes when enabling/disabling fails - Add tests for manual/automatic rotation - Move ListRealmsWithAutoKeyRotation() into a scope on ListRealms - Add `pagination.UnlimitedResults` - Remove testUser for auditing (use SystemTest instead) - Add comment on why Cloud Scheduler schedule is weird
googlebot
added
the
cla: yes
|
/assign @whaught |
|
/retest |
whaught
approved these changes
Jan 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mikehelmick
reviewed
Jan 16, 2021
|
|
||
| {{else}} | ||
| <div class="alert alert-info"> | ||
| <p><strong>Enable automatic key rotation</strong>. | ||
| It is possible to have the system automatically rotate your verification certificate signing key. | ||
| This is highly recommended, but requires that your key server is configured using the JWKS public key | ||
| discover doc. | ||
| discover doc. |
There was a problem hiding this comment.
discovery (sorry - my typo)
| @@ -48,6 +49,13 @@ type PageParams struct { | |||
| Limit uint64 | |||
| } | |||
|
|
|||
| // UnlimitedResults is a paginator that doesn't do pagination and returns all | |||
| // results (up to (1<<63)-1). | |||
| var UnlimitedResults = &PageParams{ | |||
There was a problem hiding this comment.
thanks - that's why I wrote a custom method...
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few cleanup items from #1614:
pagination.UnlimitedResultsRelease Note