This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add verification certificate key auto rotation #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
/retest |
whaught
reviewed
Jan 16, 2021
| resource "google_cloud_scheduler_job" "realm-key-rotation-worker" { | ||
| name = "realm-key-rotation-worker" | ||
| region = var.cloudscheduler_location | ||
| schedule = "2,32 * * * *" |
There was a problem hiding this comment.
2,32... those are oddly specific minutes
There was a problem hiding this comment.
offsetting it from the token rotation (which is every 5 minutes)
mikehelmick
force-pushed
the
issue1567
branch
from
fb7caae
to
d558ead
Compare
whaught
approved these changes
Jan 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sethvargo
reviewed
Jan 16, 2021
| @@ -277,6 +277,8 @@ func (i *TestInstance) NewDatabase(tb testing.TB, cacher cache.Cacher) (*Databas | |||
| tb.Fatalf("failed to load database configuration: %s", err) | |||
| } | |||
| db.keyManager = keys.TestKeyManager(tb) | |||
| db.config.CertificateSigningKeyRing = "certificates" | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1567
Proposed Changes
New enable screen
Confirmation dialog
Status when enabled
New keys are created in inactive state to allow for propagation of public key
Release Note