Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add stats-puller harness #1603

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Add stats-puller harness #1603

merged 3 commits into from
Jan 15, 2021

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Jan 15, 2021 •
edited
Loading

Issue #1512

Proposed Changes

  • Adds all the boilerplate for a new service
    • build, deploy, promo scripts
    • main entry point
    • config file
    • controller which is currently a no-op
    • terraform script for accounts, service, and cloud-scheduler (hourly)

see Seth's similar PR for rotation

Release Note

Adds the stats-puller service to run every hour.

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 15, 2021
sethvargo
sethvargo approved these changes Jan 15, 2021
View reviewed changes
terraform/alerting/slos.tf
@@ -40,6 +40,7 @@ locals {
server = merge(local.default_per_service_slo,
{ enable_latency_alert = true,
latency_threshold = 2000 })
stats-puller = local.default_per_service_slo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably do this for rotation too, huh

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 906ff33 into google:main Jan 15, 2021
@whaught whaught deleted the stats-harness branch January 15, 2021 19:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whaught @google-oss-robot @sethvargo @googlebot