This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add rotation harness and rotate token signing keys #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new service, rotation, which handles key and rotation events. It's designed to be invoked via Cloud Scheduler and has its own locking and time intervals. It's conceptually similar to the cleanup job. This also adds the database schema and example rotation for token signing keys. Note that this code is NOT in use in main code paths yet.
google-cla
bot
added
the
cla: yes
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
/assign @whaught It'd be good to get 2 LGTMs on this |
sethvargo
commented
Jan 14, 2021
| Port string `env:"PORT,default=8080"` | ||
|
|
||
| RateLimit uint64 `env:"RATE_LIMIT,default=60"` |
| @@ -93,6 +96,7 @@ func (c *Controller) HandleCleanup() http.Handler { | |||
| OK: false, | |||
| Errors: []error{fmt.Errorf("too early")}, | |||
| }) | |||
| return | |||
There was a problem hiding this comment.
This is an existing nasty bug in the cleanup server.
whaught
reviewed
Jan 14, 2021
Done |
whaught
approved these changes
Jan 15, 2021
mikehelmick
approved these changes
Jan 15, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new service, rotation, which handles key and rotation events. It's designed to be invoked via Cloud Scheduler and has its own locking and time intervals. It's conceptually similar to the cleanup job.
This also adds the database schema and example rotation for token signing keys. Note that this code is NOT in use in main code paths yet.
There's some TODOs in the code assigned to me. I intend to do those in follow-up PRs where all of this will be wired together.
Part of #1569
Release Note
/assign @mikehelmick