Add handling of FutureCombiner.callAsync #4879
Merged
+187
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_733505792
branch
5 times, most recently
from
ed45b7c to
931564e
Compare
The initial bug pattern covered `Futures.transformAsync`. I recently noticed a similar issue with `FutureCombiner.callAsync`. Given that logic is pretty much identical and that `FutureCombiner` is a subclass of `Futures`, I have extended the existing bug pattern. PiperOrigin-RevId: 735566050
copybara-service
bot
force-pushed
the
test_733505792
branch
from
931564e to
82dbc53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handling of FutureCombiner.callAsync
The initial bug pattern covered
Futures.transformAsync. I recently noticed a similar issue withFutureCombiner.callAsync. Given that logic is pretty much identical and thatFutureCombineris a subclass ofFutures, I have extended the existing bug pattern.