-
Notifications
You must be signed in to change notification settings - Fork 750
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add handling of FutureCombiner.callAsync
The initial bug pattern covered `Futures.transformAsync`. I recently noticed a similar issue with `FutureCombiner.callAsync`. Given that logic is pretty much identical and that `FutureCombiner` is a subclass of `Futures`, I have extended the existing bug pattern. PiperOrigin-RevId: 733505792
- Loading branch information
1 parent
eac11e5
commit 931564e
Showing
3 changed files
with
187 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
The usage of `transformAsync` is not necessary when all the return values of the | ||
transformation function are immediate futures. In this case, the usage of | ||
`transform` is preferred. | ||
The usage of `transformAsync` and `callAsync` is not necessary when all the | ||
return values of the transformation function are immediate futures. In this | ||
case, the usage of `transform` and `call` is preferred. | ||
|
||
Note that `transform` cannot be used if the body of the transformation function | ||
throws checked exceptions. |