Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill the remaining glossary definitions #1468

Closed

Conversation

ANURAGSISODIYAA
Copy link
Contributor

@ANURAGSISODIYAA ANURAGSISODIYAA commented Nov 11, 2023

fixes #1466

Copy link

google-cla bot commented Nov 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hamidrezakp
Copy link
Collaborator

Oh thanks man,
@moaminsharifi, Can you update and translate this parts after this PR lands?

@moaminsharifi
Copy link
Collaborator

Oh thanks man, @moaminsharifi, Can you update and translate this parts after this PR lands?

I can translate those, but it will take me some time since my PR queue is busy at the moment.

Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the explanations here, they're top-notch! Thanks a ton for adding all the links to the individual pages, that's a lot of work!

We just need to incorporate the changes using the right process, as explained in my other comments.

po/fa.po Outdated Show resolved Hide resolved
@ANURAGSISODIYAA
Copy link
Contributor Author

Oh Soory ! I would correct the formatig.

Copy link
Contributor Author

@ANURAGSISODIYAA ANURAGSISODIYAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated glossary terms in correct format and also filled some missing terms

@mgeisler
Copy link
Collaborator

Oh Soory ! I would correct the formatig.

Thanks for fixing the formatting! Please don't edit po/fa.po directly, instead edit src/glossary.md.

All changes to the msgid fields must go via changes to the English text in the Markdown files. That is the basis for the translation system — your changes to the msgid fields will be lost the next time someone uses msgmerge --update to update the po/fa.po file.

@mgeisler mgeisler changed the title filled the remaining defintions of the English glossary Fill the remaining glossary definitions Nov 12, 2023
@mgeisler
Copy link
Collaborator

I think we can close this now that we have #1466 merged!

The glossary terms will flow into the Persian translation on the next refresh.

@mgeisler
Copy link
Collaborator

Thanks for #1466, which makes this obsolete.

@mgeisler mgeisler closed this Nov 16, 2023
@ANURAGSISODIYAA ANURAGSISODIYAA deleted the Fil/English-glossary branch November 16, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill out the English glossary
4 participants