Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filled missing glossary terms with their explanations #1473

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ANURAGSISODIYAA
Copy link
Contributor

@ANURAGSISODIYAA ANURAGSISODIYAA commented Nov 12, 2023

Changes Made
This Pull Request addresses issue #1466 and includes the following changes:
Added Glossary Terms: Filled in missing glossary terms with their respective explanations.

Context
The glossary is a crucial reference for understanding key terms in the project. This PR enhances its completeness and readability by adding missing terms and improving the overall formatting.

Related Issues

Fixes #1466.

@ANURAGSISODIYAA ANURAGSISODIYAA changed the title Added missing glossary terms with their explanations Filled missing glossary terms with their explanations Nov 13, 2023
Copy link
Collaborator

@randomPoison randomPoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These definitions are excellent, thanks for getting these written!

@randomPoison
Copy link
Collaborator

@mgeisler It looks like the Brazilian Portuguese translation is failing in CI for some reason, even though this PR doesn't seem to touch anything related to the tests that are failing. Any idea what's going on here? I'm not terribly familiar with the translations work.

@mgeisler
Copy link
Collaborator

@mgeisler It looks like the Brazilian Portuguese translation is failing in CI for some reason, even though this PR doesn't seem to touch anything related to the tests that are failing. Any idea what's going on here?

Yes, we had a race between two PRs: #1460, which updated our tooling, and #1467 which updated a translation to the new format. This was fixed in #1472 and I'll simply trigger a rerun of the GH actions.

@mgeisler mgeisler enabled auto-merge (squash) November 15, 2023 09:19
@mgeisler mgeisler merged commit 5ffcac5 into google:main Nov 15, 2023
51 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill out the English glossary
3 participants