Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Korean translation #925

Closed
mgeisler opened this issue Jul 10, 2023 · 10 comments
Closed

Refresh Korean translation #925

mgeisler opened this issue Jul 10, 2023 · 10 comments
Assignees

Comments

@mgeisler
Copy link
Collaborator

The Korean translation has fallen behind and needs to be refreshed.

This is a continuation of #262.

mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
mgeisler added a commit that referenced this issue Jul 10, 2023
@mgeisler
Copy link
Collaborator Author

mgeisler commented Aug 9, 2023

The content PRs are all merged now! I created #1058 to update the messages with the English source texts.

yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for enums

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for running-the-course

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

* Rebase and move translations to correct spot

I believe the PO file would benefit from a msgmerge run. I’ll let the
translators do this after merging all outstanding translations.

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for credits

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for SUMMARY

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for control-flow

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for welcome

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for basic-syntax

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

* Update po/ko.po

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for testing

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for structs

Part of google#925.

* Fix missing `\n` po/ko.po
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for modules

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

* Update po/ko.po

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
Part of google#925.

Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for generics

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

* ko: move translation back to where it belongs

This paragraph is likely outdated, but moving it here helps avoid
conflicts. The outdated paragraph can be cleaned up with `msgmerge` at
a later point.

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for pattern-matching

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

* ko: move translation back to where it belongs

This is likely outdated, but moving it here helps avoid conflicts. The
outdated paragraph can be cleaned up with `msgmerge` at a later point.

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for android

Part of google#925.

* ko: move translations back to where they belong

Moving them back helps avoid conflicts. The outdated paragraphs can be
cleaned up with `msgmerge` at a later point.
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for concurrency

Part of google#925.

* ko: move translation back to where it belongs

This is likely outdated, but moving it here helps avoid conflicts. The
outdated paragraph can be cleaned up with `msgmerge` at a later point.
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for error-handling

Part of google#925.

* ko: move translations back to where they belong

Moving them back helps avoid conflicts. The outdated messages can be
cleaned up with `msgmerge` at a later point.
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
* ko: refresh translation for async

Part of google#925.

* Apply suggestions from code review

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

* ko: move translations back to where they belong

Moving them back helps avoid conflicts. The outdated messages can be
cleaned up with `msgmerge` at a later point.

---------

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this issue Sep 12, 2023
Part of google#925.

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
@mgeisler
Copy link
Collaborator Author

mgeisler commented Nov 9, 2023

Hi all! I wanted to let you know about #1460. This is an update to mdbook-i18n-helpers which will remove ~6k lines from your PO file. It changes the way code blocks are processed: we now extract strings and comments directly.

You need to run mdbook-i18n-normalize on your PO file to preserve the translations found here: https://google.github.io/comprehensive-rust/ko/hello-world/small-example.html (and any other places where you have translated comments).

You can do this before/after refreshing the translation. See #1461 for an example PR which shows the state after normalization.

@henrif75
Copy link
Collaborator

Closing this issue since we're done with the core translation work on v.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants