Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 668: Fix logging out on windows #684

Merged
merged 5 commits into from
Aug 19, 2019
Merged

Issue 668: Fix logging out on windows #684

merged 5 commits into from
Aug 19, 2019

Conversation

B-E-A-F
Copy link
Contributor

@B-E-A-F B-E-A-F commented Aug 14, 2019

Fixes #668

I removed the del library, as it was only used in this one location. For more info read Issue.

There was a comment about relative paths not working for the del library? That may or may not be relevant now, but I looked over the functionality and I believe that you still need both lines.

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

@B-E-A-F
Copy link
Contributor Author

B-E-A-F commented Aug 14, 2019

Forgot to run the linter 😭. I see some code that was actually merged with some linting issues as well.

@grant
Copy link
Contributor

grant commented Aug 14, 2019

Thanks!

Here's the error from Travis:

ERROR: /home/travis/build/google/clasp/src/commands/openCmd.ts:73:71 - Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type.
ERROR: /home/travis/build/google/clasp/src/commands/openCmd.ts:76:39 - Missing trailing comma

Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@grant grant merged commit 6303ae1 into google:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests not working on Windows
3 participants