Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not working on Windows #668

Closed
B-E-A-F opened this issue Jul 21, 2019 · 5 comments · Fixed by #684
Closed

Tests not working on Windows #668

B-E-A-F opened this issue Jul 21, 2019 · 5 comments · Fixed by #684

Comments

@B-E-A-F
Copy link
Contributor

B-E-A-F commented Jul 21, 2019

Expected Behavior

SpawnSync should output the appropriate stdout when running tests.

I'm currently running into an issue where Windows Virtual Terminal Sequences are being outputted. On multiple tests I get: expected '\u001b[2K\u001b[1G' to include 'string from test here'.

I've been running the tests on git bash for windows. When I ran this on command prompt I get the same issue as well.

I'm a little stumped on this one, and spent a few days trying to fix.

May be related to #231

Actual Behavior

The tests should output the appropriate stdout on Windows.

Steps to Reproduce the Problem

  1. Run the tests on Windows 10

Specifications

  • Node version (node -v): 12.4.0
  • Version (clasp -v): 2.2.1
  • OS (Mac/Linux/Windows): Windows 10 Version 1809
@B-E-A-F
Copy link
Contributor Author

B-E-A-F commented Jul 26, 2019

@wilt00 Do you possibly have any information that may lead me into the right direction?

@PopGoesTheWza
Copy link
Collaborator

Recently merged PR #662 changes how tests are run. It might be good to check if your issue is affected by this change.

@wilt00
Copy link
Contributor

wilt00 commented Jul 27, 2019

@mikearche Unfortunately I stopped running Windows a few months ago, and don't have access to a Windows box for testing any longer. Sorry!

@B-E-A-F
Copy link
Contributor Author

B-E-A-F commented Jul 27, 2019

#662 should at least make this easier to debug... But unfortunately, I'm still getting the errors.

I'll keep looking into it in the mean time.

@B-E-A-F
Copy link
Contributor Author

B-E-A-F commented Jul 28, 2019

So I believe that I've fixed one of the issues.

I can go ahead and create a PR, but there are still a couple of failing tests on windows. For some reason I believe the google api calls are causing the result to have a status of 1, but they're getting the correct stdout... This is specifically for the logs setup tests, and the clasp version tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants