-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests not working on Windows #668
Comments
@wilt00 Do you possibly have any information that may lead me into the right direction? |
Recently merged PR #662 changes how tests are run. It might be good to check if your issue is affected by this change. |
@mikearche Unfortunately I stopped running Windows a few months ago, and don't have access to a Windows box for testing any longer. Sorry! |
#662 should at least make this easier to debug... But unfortunately, I'm still getting the errors. I'll keep looking into it in the mean time. |
So I believe that I've fixed one of the issues.
I can go ahead and create a PR, but there are still a couple of failing tests on windows. For some reason I believe the google api calls are causing the result to have a status of 1, but they're getting the correct stdout... This is specifically for the logs setup tests, and the clasp version tests. |
Expected Behavior
SpawnSync should output the appropriate stdout when running tests.
I'm currently running into an issue where Windows Virtual Terminal Sequences are being outputted. On multiple tests I get:
expected '\u001b[2K\u001b[1G' to include 'string from test here'
.I've been running the tests on git bash for windows. When I ran this on command prompt I get the same issue as well.
I'm a little stumped on this one, and spent a few days trying to fix.
May be related to #231
Actual Behavior
The tests should output the appropriate stdout on Windows.
Steps to Reproduce the Problem
Specifications
node -v
): 12.4.0clasp -v
): 2.2.1The text was updated successfully, but these errors were encountered: