Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the IVariableMap and IVariableModel interfaces. #8369

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

gonfunko
Copy link
Contributor

The basics

The details

Resolves

Fixes #8072.

Proposed Changes

This PR adds formal interfaces for variable maps and models.

Reason for Changes

This is needed to enable Scratch to upgrade to modern Blockly, and adds useful extension APIs for all developers.

@gonfunko gonfunko requested a review from BeksOmega July 15, 2024 21:57
@gonfunko gonfunko requested a review from a team as a code owner July 15, 2024 21:57
@github-actions github-actions bot added the PR: feature Adds a feature label Jul 15, 2024
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after copyright statements are added.

@@ -0,0 +1,66 @@
import {IVariableModel} from './i_variable_model.js';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright statement plox. Here and in the other file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@gonfunko gonfunko merged commit aecfe34 into google:rc/v12.0.0 Jul 15, 2024
7 checks passed
@gonfunko gonfunko deleted the variables branch July 15, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants