-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed Blockly.connectionTypes to Blockly.ConnectionType for consistency #5402
Conversation
Renamed Blockly.connectionTypes to Blockly.ConnectionType for consistency. Additional context
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent |
Hi @himanshujaidka thank you so much for putting up this PR! This issue is actually part of a larger refactor we're doing, so I'm not sure which branch this is supposed to go into, or if we want to wait to put this in. I've put it on the internal meeting docs to discuss next week. So it may be a bit before I have info on this =) If you want something else to work on in the mean time, #4993 looks like a good starter issue. Sorry about the wait :/ If there's anything I can help you with don't hesitate to ask! Thank you again :D |
@BeksOmega, Thanks mam for your support I am looking into the mentioned issue, but please guide me that how to set up this app on the local system 😅 I have tried and read all the documentation related to this but am unable to set up this on my local machine. And I think to test the #4993 issue we need macOS but I have windows |
Oh whoops my bad! Yeah that is not going to work haha. If you're on Windows we would actually love help with #5000. Or if you want to do some more coding #4784 might be fun. Just so you know, anything marked help wanted is fair game to work on =) But I also have good news with regard to this PR! The team talked it over yesterday, and we would love to merge this PR... but into the
I'm happy to help with either method if you run into any trouble! But if it sounds like a pain, feel free to just close this PR and work on a different issue as well =) Sorry changing things on you again haha. But we do really appreciate you contributing! Getting bugs like this fixed is so helpful =) |
@BeksOmega okay I will create a new pr against |
The basics
The details
Resolves
Proposed Changes
Behavior Before Change
Blockly.connectionTypes
Additional context
Behavior After Change
Blockly.ConnectionType
Additional context
Reason for Changes
Renamed Blockly.connectionTypes to Blockly.ConnectionType for consistency.
Additional context
issue linked #5156