Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number fields accepting infinity is opaque #4784

Open
BeksOmega opened this issue Apr 17, 2021 · 0 comments
Open

Number fields accepting infinity is opaque #4784

BeksOmega opened this issue Apr 17, 2021 · 0 comments
Labels
component: fields issue: docs Describes missing or incorrect documentation

Comments

@BeksOmega
Copy link
Collaborator

Description

By default, Blockly's number input fields accept values of 'Infinity', 'infinity', '-Infinity', and '-infinity' (source code). This behavior may not be expected by developers, and could cause them issues if they are expecting their inputs to be finite.

Recommendation

Some things that could help resolve this issue are:

  1. Documenting this behavior on the number fields page.
  2. Adding a parameter to the number field config to make it only accept finite values.

But I'm not sure which of those are necessary/useful.

Additional Info

See the linked issues below this issue for an example of where this causes a problem.

@BeksOmega BeksOmega added issue: triage Issues awaiting triage by a Blockly team member issue: docs Describes missing or incorrect documentation labels Apr 17, 2021
@alschmiedt alschmiedt added component: fields and removed issue: triage Issues awaiting triage by a Blockly team member labels Apr 26, 2021
@alschmiedt alschmiedt added this to the Bug Bash Backlog milestone Apr 26, 2021
@BeksOmega BeksOmega added the help wanted External contributions actively solicited label Aug 24, 2021
@BeksOmega BeksOmega removed the help wanted External contributions actively solicited label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: fields issue: docs Describes missing or incorrect documentation
Projects
None yet
Development

No branches or pull requests

2 participants