Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue that prevented Mocha and generator tests from running on certain configurations #5344

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Fix issue that prevented Mocha and generator tests from running on certain configurations #5344

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e1cf10
Fix issue that prevented Mocha and generator tests from running on ce…
gonfunko Aug 10, 2021
1253ca5
Link to Blockly issue re: --disable-gpu flag
gonfunko Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/generators/run_generators_in_browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ async function runGeneratorsInBrowser() {
args: ['--headless', '--no-sandbox', '--disable-dev-shm-usage', '--allow-file-access-from-files']
};
} else {
// --disable-gpu is needed to prevent Chrome from hanging on Linux with
// NVIDIA drivers older than v295.20.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a link here and below to #5345 so we have the future context, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

options.capabilities['goog:chromeOptions'] = {
args: ['--allow-file-access-from-files']
args: ['--allow-file-access-from-files', '--disable-gpu']
};
}

Expand Down
4 changes: 3 additions & 1 deletion tests/mocha/run_mocha_tests_in_browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ async function runMochaTestsInBrowser() {
]
};
} else {
// --disable-gpu is needed to prevent Chrome from hanging on Linux with
// NVIDIA drivers older than v295.20.
options.capabilities['goog:chromeOptions'] = {
args: ['--allow-file-access-from-files']
args: ['--allow-file-access-from-files', '--disable-gpu']
};
}

Expand Down