Fix issue that prevented Mocha and generator tests from running on certain configurations #5344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtain configurations
maribethb
reviewed
Aug 10, 2021
| @@ -51,8 +51,10 @@ async function runGeneratorsInBrowser() { | |||
| args: ['--headless', '--no-sandbox', '--disable-dev-shm-usage', '--allow-file-access-from-files'] | |||
| }; | |||
| } else { | |||
| // --disable-gpu is needed to prevent Chrome from hanging on Linux with | |||
| // NVIDIA drivers older than v295.20. | |||
There was a problem hiding this comment.
Could you add a link here and below to #5345 so we have the future context, please?
maribethb
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the --disable-gpu flag to the run mocha/generator test scripts, which works around an issue where Chrome would hang when running the tests on Linux with older versions of the NVIDIA driver.
This fixes #5345.