Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle authorization response and return result object. #426

Merged
merged 75 commits into from
Jun 17, 2024
Merged

Handle authorization response and return result object. #426

merged 75 commits into from
Jun 17, 2024

Commits on Apr 17, 2024

  1. Create method verifyAccountDetailsInteractivelyWithOptions.

    @brnnmrls
    brnnmrls committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    54df794 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Move configuration creation methods to GIDConfiguration from GIDSignIn.

    @brnnmrls
    brnnmrls committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5896985 View commit details
    Browse the repository at this point in the history

  2. Implement default options creation methods.

    @brnnmrls
    brnnmrls committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    94a4175 View commit details
    Browse the repository at this point in the history

  3. Options validation.

    @brnnmrls
    brnnmrls committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4c2a643 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Add config initializers.

    @brnnmrls
    brnnmrls committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    78e175d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'briannamorales/vwg-flow' into briannamorales/optionsVal… 

    …idation
    @brnnmrls
    brnnmrls committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    731d3a8 View commit details
    Browse the repository at this point in the history

  3. Fix spacing.

    @brnnmrls
    brnnmrls committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a5b9a61 View commit details
    Browse the repository at this point in the history

  4. Add import to use GIDAccountDetailTypeAgeOver18.

    @brnnmrls
    brnnmrls committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d70400a View commit details
    Browse the repository at this point in the history

  5. Import GIDConfiguration to test file.

    @brnnmrls
    brnnmrls committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f858d20 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Create OIDAuthorizationRequest.

    @brnnmrls
    brnnmrls committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4a97c00 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Add tests for config initializers.

    @brnnmrls
    brnnmrls committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c4d0a16 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Add in initializer with config tests.

    @brnnmrls
    brnnmrls committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e04a1ea View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Make used variables properties.

    @brnnmrls
    brnnmrls committed May 2, 2024
    Configuration menu
    Copy the full SHA
    93fb453 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'briannamorales/optionsValidation' into briannamorales/p… 

    …resentAuthorizationRequest
    @brnnmrls
    brnnmrls committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8441f85 View commit details
    Browse the repository at this point in the history

  3. Add TODO for request/response handling tests.

    @brnnmrls
    brnnmrls committed May 2, 2024
    Configuration menu
    Copy the full SHA
    066fa07 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Exclude MacOS for GIDEMMSupport use.

    @brnnmrls
    brnnmrls committed May 3, 2024
    Configuration menu
    Copy the full SHA
    dc6560b View commit details
    Browse the repository at this point in the history

  2. Silence unused 'request' variable for now until response is implemented.

    @brnnmrls
    brnnmrls committed May 3, 2024
    Configuration menu
    Copy the full SHA
    fa7845c View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Implement method to process authorization response.

    @brnnmrls
    brnnmrls committed May 6, 2024
    Configuration menu
    Copy the full SHA
    986c1da View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Add tests for config initializer and current user exception.

    @brnnmrls
    brnnmrls committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8bfd659 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Create fake main bundle initializer and modify tests.

    @brnnmrls
    brnnmrls committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9376a4b View commit details
    Browse the repository at this point in the history

  2. Remove Emm flow support and move GIDSignIn strings to avoid repeated … 

    …code.
    @brnnmrls
    brnnmrls committed May 8, 2024
    Configuration menu
    Copy the full SHA
    4cebc05 View commit details
    Browse the repository at this point in the history

  3. Unblock testing in GIDVerifyAccountDetailTest by changing GIDSignInTe… 

    …st strict mocks to less restrictive. Also, fix nullability warnings in GIDFakeMainBundle.
    @brnnmrls
    brnnmrls committed May 8, 2024
    Configuration menu
    Copy the full SHA
    51c5a36 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Address formatting and indicate designated initializer in GIDFakeMain… 

    …Bundle.
    @brnnmrls
    brnnmrls committed May 9, 2024
    Configuration menu
    Copy the full SHA
    6ce9f10 View commit details
    Browse the repository at this point in the history

  2. Add stopFaking calls in appropriate tests.

    @brnnmrls
    brnnmrls committed May 9, 2024
    Configuration menu
    Copy the full SHA
    4d981eb View commit details
    Browse the repository at this point in the history

  3. Fix indentation and remove parameter from additionalParameters.

    @brnnmrls
    brnnmrls committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b744a4b View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Let parameter-less init be nullable and require initWithConfig to… 

    … pass a configuration.
    @brnnmrls
    brnnmrls committed May 10, 2024
    Configuration menu
    Copy the full SHA
    89b92d3 View commit details
    Browse the repository at this point in the history

  2. Create GIDSignInConstants class to hold common constants across the… 

    … sign-in and verify flow.
    @brnnmrls
    brnnmrls committed May 10, 2024
    Configuration menu
    Copy the full SHA
    78daa0b View commit details
    Browse the repository at this point in the history

  3. Fix method description and make initWithConfig nullable.

    @brnnmrls
    brnnmrls committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7112ce5 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Merge branch 'briannamorales/presentAuthorizationRequest' into briann… 

    …amorales/processAuthorizationResponse
    @brnnmrls
    brnnmrls committed May 11, 2024
    Configuration menu
    Copy the full SHA
    c9f6d9d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'briannamorales/optionsValidation' into briannamorales/p… 

    …resentAuthorizationRequest
    @brnnmrls
    brnnmrls committed May 11, 2024
    Configuration menu
    Copy the full SHA
    241d72e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'briannamorales/presentAuthorizationRequest' into briann… 

    …amorales/processAuthorizationResponse
    @brnnmrls
    brnnmrls committed May 11, 2024
    Configuration menu
    Copy the full SHA
    1e4cb16 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Fix formatting and add openIDRealm param.

    @brnnmrls
    brnnmrls committed May 13, 2024
    Configuration menu
    Copy the full SHA
    2023dbb View commit details
    Browse the repository at this point in the history

  2. Add missing AppAuth/OID imports.

    @brnnmrls
    brnnmrls committed May 13, 2024
    Configuration menu
    Copy the full SHA
    52429b7 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'briannamorales/vwg-flow' into briannamorales/presentAut… 

    …horizationRequest
    @brnnmrls
    brnnmrls committed May 14, 2024
    Configuration menu
    Copy the full SHA
    674ec5f View commit details
    Browse the repository at this point in the history

  2. Move constants to GIDSignInConstants and update doc comments.

    @brnnmrls
    brnnmrls committed May 14, 2024
    Configuration menu
    Copy the full SHA
    aac80b4 View commit details
    Browse the repository at this point in the history

  3. Update preprocessor directives to exclude TARGET_OS_MACCATALYST.

    @brnnmrls
    brnnmrls committed May 14, 2024
    Configuration menu
    Copy the full SHA
    298d9c4 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Move GIDVerifyAuthFlow into separate files and change integer value… 

    …s in `GIDVerifyCode` to positive.
    @brnnmrls
    brnnmrls committed May 15, 2024
    Configuration menu
    Copy the full SHA
    d220aa7 View commit details
    Browse the repository at this point in the history

  2. Fix formatting.

    @brnnmrls
    brnnmrls committed May 15, 2024
    Configuration menu
    Copy the full SHA
    227f3e3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'briannamorales/presentAuthorizationRequest' into briann… 

    …amorales/processAuthorizationResponse
    @brnnmrls
    brnnmrls committed May 15, 2024
    Configuration menu
    Copy the full SHA
    570af10 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Create GIDAuthFlow class to group properties in authentication flow.

    @brnnmrls
    brnnmrls committed May 17, 2024
    Configuration menu
    Copy the full SHA
    02e047a View commit details
    Browse the repository at this point in the history

  2. Create class GIDAuthorizationResponseHelper to process authorizatio… 

    …n response in sign-in and verify flow.
    @brnnmrls
    brnnmrls committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f42581b View commit details
    Browse the repository at this point in the history

  3. Reduce code duplication between flows using class `GIDAuthorizationRe… 

    …sponseHelper`.
    @brnnmrls
    brnnmrls committed May 17, 2024
    Configuration menu
    Copy the full SHA
    5249ae9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'briannamorales/vwg-flow' into briannamorales/processAut… 

    …horizationResponse
    @brnnmrls
    brnnmrls committed May 17, 2024
    Configuration menu
    Copy the full SHA
    bad0713 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Add preprocessor directives to GIDAuthorizationResponseHelper.

    @brnnmrls
    brnnmrls committed May 18, 2024
    Configuration menu
    Copy the full SHA
    2f6d0fe View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Return instance in GIDAuthorizationResponseHelper initializer.

    @brnnmrls
    brnnmrls committed May 20, 2024
    Configuration menu
    Copy the full SHA
    061b76b View commit details
    Browse the repository at this point in the history

  2. Add test for GIDAuthorizationResponseHelper.

    @brnnmrls
    brnnmrls committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e3a8b3d View commit details
    Browse the repository at this point in the history

  3. Add documentation and error handling.

    @brnnmrls
    brnnmrls committed May 20, 2024
    Configuration menu
    Copy the full SHA
    34df266 View commit details
    Browse the repository at this point in the history

  4. Add properties and initializer to GIDVerifiedAccountDetailResult class.

    @brnnmrls
    brnnmrls committed May 20, 2024
    Configuration menu
    Copy the full SHA
    25d5624 View commit details
    Browse the repository at this point in the history

  5. Handle response by creating and calling completion callback method.

    @brnnmrls
    brnnmrls committed May 20, 2024
    Configuration menu
    Copy the full SHA
    0e41187 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Add designated initializer to GIDAuthFlow.

    @brnnmrls
    brnnmrls committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5953f4e View commit details
    Browse the repository at this point in the history

  2. Update documentation, constant names, and `GIDAuthorizationResponseHe… 

    …lper`'s initializer.
    @brnnmrls
    brnnmrls committed May 21, 2024
    Configuration menu
    Copy the full SHA
    77752d8 View commit details
    Browse the repository at this point in the history

  3. Add issue to clean up callback flow in the future.

    @brnnmrls
    brnnmrls committed May 21, 2024
    Configuration menu
    Copy the full SHA
    06ff4d2 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Add GIDAuthorizationResponseHandling and fake for testing.

    @brnnmrls
    brnnmrls committed May 24, 2024
    Configuration menu
    Copy the full SHA
    60f276c View commit details
    Browse the repository at this point in the history

  2. Remove extra fetch token call to fix tests.

    @brnnmrls
    brnnmrls committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5999eb0 View commit details
    Browse the repository at this point in the history

  3. Add doc comment to responseHandler param.

    @brnnmrls
    brnnmrls committed May 24, 2024
    Configuration menu
    Copy the full SHA
    fab6b41 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Move GIDAuthorizationResponse related files to designated directories.

    @brnnmrls
    brnnmrls committed May 29, 2024
    Configuration menu
    Copy the full SHA
    7dc4c28 View commit details
    Browse the repository at this point in the history

  2. Add testing for class GIDAuthorizationResponseHelper.

    @brnnmrls
    brnnmrls committed May 29, 2024
    Configuration menu
    Copy the full SHA
    6228850 View commit details
    Browse the repository at this point in the history

  3. Add imports and preprocessor directives to testing.

    @brnnmrls
    brnnmrls committed May 29, 2024
    Configuration menu
    Copy the full SHA
    23c3d17 View commit details
    Browse the repository at this point in the history

  4. Fix test with no authorization code.

    @brnnmrls
    brnnmrls committed May 29, 2024
    Configuration menu
    Copy the full SHA
    0d56794 View commit details
    Browse the repository at this point in the history

  5. Add method to let the user refresh tokens with a passed auth state.

    @brnnmrls
    brnnmrls committed May 29, 2024
    Configuration menu
    Copy the full SHA
    2dc6e14 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'briannamorales/processAuthorizationResponse' into brian… 

    …namorales/handleAuthorizationResponse
    @brnnmrls
    brnnmrls committed May 29, 2024
    Configuration menu
    Copy the full SHA
    0ca4cbb View commit details
    Browse the repository at this point in the history

  7. Import OIDAuthState to GIDVerifiedAccountDetailResult class.

    @brnnmrls
    brnnmrls committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e3a3dfd View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Add new detail to GIDAccountDetailType to indicate there was an error… 

    … verifying.
    @brnnmrls
    brnnmrls committed May 30, 2024
    Configuration menu
    Copy the full SHA
    1d1ae64 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Add tests and create handling for GIDVerifiedAccountDetailResult class.

    @brnnmrls
    brnnmrls committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9cc4df9 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Add GIDVerifiedaccountDetailResultHandling protocol to public folder.

    @brnnmrls
    brnnmrls committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    756cc84 View commit details
    Browse the repository at this point in the history

  2. Add tests for GIDVerifiedAccountDetailResult class.

    @brnnmrls
    brnnmrls committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    5c25d97 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Rename GIDVerifiedAccountDetailResultFake to `GIDVerifiedAccountDet… 

    …ailResultHandlingFake`.
    @brnnmrls
    brnnmrls committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    69a6d59 View commit details
    Browse the repository at this point in the history

  2. Check equality between GIDVerifiableAccountDetail objects.

    @brnnmrls
    brnnmrls committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e3e4177 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Stop mocking auth state ivar to keep from carrying over to subsequent… 

    … tests.
    @brnnmrls
    brnnmrls committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    19de2dc View commit details
    Browse the repository at this point in the history

  2. Import OIDScopeUtilities to utilize scopesArrayWithString.

    @brnnmrls
    brnnmrls committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    1064fa1 View commit details
    Browse the repository at this point in the history

  3. Add imports to fix failing tests.

    @brnnmrls
    brnnmrls committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    eeb2018 View commit details
    Browse the repository at this point in the history

  4. Make naming changes and add missing availability declarations.

    @brnnmrls
    brnnmrls committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2692e2c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'briannamorales/vwg-flow' into briannamorales/handleAuth… 

    …orizationResponse
    @brnnmrls
    brnnmrls committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6b6490e View commit details
    Browse the repository at this point in the history

  6. Fix naming and doc comment.

    @brnnmrls
    brnnmrls committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    9011e74 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Update properties of GIDVerifiedAccountDetailResult upon refresh. A… 

    …lso, add `hash` methods to overridden `isEqual:` methods.
    @brnnmrls
    brnnmrls committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    31ea7f7 View commit details
    Browse the repository at this point in the history