Handle authorization response and return result object. #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resentAuthorizationRequest
…st strict mocks to less restrictive. Also, fix nullability warnings in GIDFakeMainBundle.
… pass a configuration.
… sign-in and verify flow.
…amorales/processAuthorizationResponse
…resentAuthorizationRequest
…namorales/handleAuthorizationResponse
brnnmrls
commented
Jun 3, 2024
Base automatically changed from
briannamorales/processAuthorizationResponse
to
briannamorales/vwg-flow
June 5, 2024 17:54
mdmathias
requested changes
Jun 12, 2024
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifiableAccountDetail.m
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifiedAccountDetailResult.m
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/Public/GoogleSignIn/GIDVerifiableAccountDetail.h
Outdated
Show resolved
Hide resolved
mdmathias
reviewed
Jun 12, 2024
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifiedAccountDetailResult.m
Show resolved
Hide resolved
…lso, add `hash` methods to overridden `isEqual:` methods.
mdmathias
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the authorization response is processed, the next step is to handle the response by passing back the necessary tokens to the requesting party. A new type is made to encapsulate the completion of the VwG flow. Items that this result object holds are expirationDate, accessTokenString, refreshTokenString, and verifiedAccountDetails. A new method
-[GIDVerifyAccountDetail addCompletionCallback:]will create a result object with these properties filled. This class also holds-[GIDVerifiedAccountDetailResult refreshTokensWithCompletion:]to allow developers refresh tokens themselves.