-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird behaviour when seek operation is performed while playing preroll ad. #8349
Comments
I have added the seek on STATE_READY in the demo app but the seek was ignored as expected:
Please provide the media with the prerolled media so we can reproduce and a bug report. If you're unable to share bug reports or test content publicly, please send them to dev.exoplayer@gmail.com using a subject in the format "Issue #1234" ("#1234" is replaced with your issue number). Please also update this issue to indicate you've done this. |
Hi @krocard , Attached video and logs for reference. In the video you can observe first preroll is completed before second preroll started and video got stuck at 1st mid-roll. Also attaching patch for seek logic. Hope this helps |
Thank you, I managed to reproduce the issue. The issue is due to ExoPlayer/library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImpl.java Lines 598 to 607 in be13805
This lead to ExoPlayer considering that an operation is still in flight, and We could call This regression was introduced by b1e9257 in 2.12.0. @icbaker could you take a look. |
Steps to Reproduce.
Observe player goes into weird state. Ad gets skipped and play randomly along with content.
100% reproducible on latest version of exo-player.
I understand exoplayer doesn't support seek during ads, but there is already a warning for this. performing this operation should not cause this issue.
The text was updated successfully, but these errors were encountered: