Fix EPI.seekTo to balance operation acks when seeking during an ad

This regression was introduced in b1e9257 Issue: #8349 PiperOrigin-RevId: 347802049
google · Jan 11, 2021 · d0e6dec · d0e6dec
1 parent ffa746f
commit d0e6dec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -2,6 +2,9 @@
 
 ### 2.12.3 (???-??-??) ###
 
+*   Core library:
+    *   Fix playback issues after seeking during an ad
+        ([#8349](https://github.com/google/ExoPlayer/issues/8349)).
 *   UI:
     *   Fix issue where pop-up menus belonging to `StyledPlayerControlView`
         would not be dismissed when tapping outside of the menu area or pressing

diff --git a/library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImpl.java b/library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImpl.java
@@ -601,8 +601,10 @@ public void seekTo(int windowIndex, long positionMs) {
       // general because the midroll ad preceding the seek destination must be played before the
       // content position can be played, if a different ad is playing at the moment.
       Log.w(TAG, "seekTo ignored because an ad is playing");
-      playbackInfoUpdateListener.onPlaybackInfoUpdate(
-          new ExoPlayerImplInternal.PlaybackInfoUpdate(playbackInfo));
+      ExoPlayerImplInternal.PlaybackInfoUpdate playbackInfoUpdate =
+          new ExoPlayerImplInternal.PlaybackInfoUpdate(this.playbackInfo);
+      playbackInfoUpdate.incrementPendingOperationAcks(1);
+      playbackInfoUpdateListener.onPlaybackInfoUpdate(playbackInfoUpdate);
       return;
     }
     @Player.State