Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an option for GLBs to apply all transforms after import #312

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

rmbrualla
Copy link
Collaborator

This is done before the meshed objects are joined, and the non-meshes objects are discarded.

This fixes issues with objects not retaining the standard orientation (e.g. the one seen when loading them on Blender), as the orientation is stored in a parent node, that is discarded during the GLB loading.

…the mesh nodes are selected and joined.

This fixes issues with objects not retaining the standard orientation (e.g. the one seen when loading them on Blender), as the orientation is stored in a parent node, that is discarded during the GLB loading.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.9%. Comparing base (8fe9429) to head (ea09d13).

Files Patch % Lines
kubric/renderer/blender.py 0.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #312     +/-   ##
=======================================
- Coverage   65.9%   65.9%   -0.1%     
=======================================
  Files         43      43             
  Lines       3578    3581      +3     
=======================================
+ Hits        2360    2361      +1     
- Misses      1218    1220      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taiya taiya merged commit fc967ac into google-research:main Mar 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants