Use esp idf v5.1.1 #171
Merged
Use esp idf v5.1.1 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 919d29f): https://golioth-firmware-sdk-doxygen-dev--pr171-use-esp-idf-5-9itl6lvr.web.app (expires Mon, 18 Sep 2023 04:16:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
|
Currently blocked by #163. The new version of ESP-IDF enables additional compiler warnings, and that causes the build to fail on some uninitialized variables in libcoap. The compiler warnings are fixed in the version of libcoap that is brought in by #163. A passing test run can be seen in #172 which has both these changes and the libcoap changes. |
hasheddan
reviewed
Sep 10, 2023
Previously, enabling size optimizations would cause a compiler error. The error has been fixed in newer versions of ESP-IDF, so we can re-enable size optimizations. See espressif/esp-idf#10322 Signed-off-by: Sam Friedman <sam@golioth.io>
v5.1.1 is the latest version of ESP-IDF Signed-off-by: Sam Friedman <sam@golioth.io>
Update README instructions to match latest supported version of ESP-IDF Signed-off-by: Sam Friedman <sam@golioth.io>
sam-golioth
force-pushed
the
use_esp_idf_5_1_1
branch
from
5ae78b8
to
919d29f
Compare
mniestroj
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest version of ESP-IDF
Fixes golioth/firmware-issue-tracker#237