Update libcoap to include support for DTLS Connection IDs #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Visit the preview URL for this PR (updated for commit 2449f83): https://golioth-firmware-sdk-doxygen-dev--pr163-feat-esp-idf-l-kdt2w4ag.web.app (expires Sun, 17 Sep 2023 21:14:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
This comment was marked as outdated.
This comment was marked as outdated.
hasheddan
force-pushed
the
feat/esp-idf-libcoap-cid
branch
from
3629a77
to
9bc438b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
hasheddan
force-pushed
the
feat/esp-idf-libcoap-cid
branch
4 times, most recently
from
8165aea
to
f756ee6
Compare
hasheddan
changed the title
hasheddan
force-pushed
the
feat/esp-idf-libcoap-cid
branch
from
f756ee6
to
6e3b80e
Compare
hasheddan
commented
Sep 6, 2023
There was a problem hiding this comment.
This is currently now only blocked on espressif/esp-idf#12177, which we could work around for the time-being by not enabling CONFIG_MBEDTLS_SSL_DTLS_CONNECTION_ID.
Updates libcoap to 4abe0ea to pick up DTLS Connection ID support, which was added in obgm/libcoap#1153. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Updates esp_idf port to accommodate the new version of libcoap, which includes updating included file names, as well as setting new config values. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
hasheddan
force-pushed
the
feat/esp-idf-libcoap-cid
branch
2 times, most recently
from
22b901d
to
4da1518
Compare
Updates the list of included headers from the new libcoap version in the Zephyr port. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Updates the list of targets in the libcoap Zephyr port to accommodate renaming and additions. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Matches the upstream change in libcoap. See obgm/libcoap@aa34b5f. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Utilizes the new layers in libcoap that allows for one layer to pass data to and from the next without explicitly specifying the type of the next layer. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Renames the libcoap zephyr files to match the new upstream naming scheme. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Sets the CID supported socket option when the mbedTLS config has been set. This will cause devices to send CIDs that are negotiated with the server, but will not request that the server does the same. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
hasheddan
force-pushed
the
feat/esp-idf-libcoap-cid
branch
2 times, most recently
from
a5c0de2
to
0efb076
Compare
Enables coredump decode in esp-idf test so that we can get a stack trace without having to access the binary. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
hasheddan
force-pushed
the
feat/esp-idf-libcoap-cid
branch
from
0a22d56
to
82ddc7e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Removes the coap_cleanup() call when ending a session as it destroys resources that are required for ongoing operation. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
hasheddan
force-pushed
the
feat/esp-idf-libcoap-cid
branch
from
bc31d6c
to
2e96970
Compare
sam-golioth
approved these changes
Sep 8, 2023
src/golioth_coap_client.c
Outdated
| @@ -966,6 +966,9 @@ golioth_client_t golioth_client_create(const golioth_client_config_t* config) { | |||
| time_t t; | |||
| srand(time(&t)); | |||
|
|
|||
| // Initialize libcoap prior to any coap_* function calls. | |||
| coap_startup(); | |||
There was a problem hiding this comment.
We should reorder this so it comes before the calls to coap_set_log_*() in this function above.
There was a problem hiding this comment.
Ah good catch -- updated!
Merged
If coap_startup() is not called prior to any other coap_* function calls, a warning is emitted. ``` coap_startup() should be called before any other coap_*() functions are called ``` This proactively calls coap_startup() to ensure the library is initialized, even though coap_new_context() will do so implicitly. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
hasheddan
force-pushed
the
feat/esp-idf-libcoap-cid
branch
from
2e96970
to
2449f83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates libcoap to 4abe0ea to pick up DTLS Connection ID support, which was
added in obgm/libcoap#1153.
Signed-off-by: Daniel Mangum georgedanielmangum@gmail.com